Re: [Xen-devel] [PATCH] xen/x86: fix linker script to work with lld

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Thu, Jun 28, 2018 at 11:35:24PM -0600, Jan Beulich wrote:
> >>> Roger Pau Monne <roger.pau@xxxxxxxxxx> 06/28/18 5:38 PM >>>
> >lld (the llvm linker) has some issues with Xen linker script. It
> >doesn't understand '||' in assert expressions:
> >
> >ld    -melf_x86_64_fbsd  -T xen.lds -N prelink.o --build-id=sha1 \
> >/root/src/xen/xen/common/symbols-dummy.o -o /root/src/xen/xen/.xen-syms.0
> >ld: error: xen.lds:260: malformed number: |
> >>>> ASSERT(__image_base__ > (((((((((261 >> 8) * 0xffff000000000000) | (261 
> >>>> << 39))) + ((1 << 39) / 2)) + (64 << 30)) + (1 << 30)) + (1 << 30))) ||
> >>>>                                                                          
> >>>>                                                                      ^
> >
> >And doesn't work properly with the 'DEFINED(foo) ? foo : ...'
> >expression:
> >
> >ld    -melf_x86_64_fbsd  -T xen.lds -N prelink.o --build-id=sha1 \
> >/root/src/xen/xen/common/symbols-dummy.o -o /root/src/xen/xen/.xen-syms.0
> >ld: error: xen.lds:233: symbol not found: efi
> >
> >Fix the first issue by using '|' instead of '||', and the second one
> >by defining the efi symbol based on the EFI define (like it was done
> >prior to commit b199c44afa).
> 
> Hmm, the second one is a direct revert of the original commit's hunk. There 
> must
> have been a reason for Daniel to change it, and hence undoing it might break 
> what
> he wants needs. You should have Cc-ed him right away.

In fact I though I Cc'ed Daniel, but I clearly didn't. Thanks.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel