Re: [Xen-devel] [PATCH v3 10/31] libxl_qmp: Move buffers to the stack of qmp_next.

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Anthony PERARD writes ("Re: [PATCH v3 10/31] libxl_qmp: Move buffers to the 
stack of qmp_next."):
> On Wed, Jun 27, 2018 at 03:32:32PM +0100, Ian Jackson wrote:
> > Anthony PERARD writes ("[PATCH v3 10/31] libxl_qmp: Move buffers to the 
> > stack of qmp_next."):
> > > That buffer is only used locally, and never reuse accross different call
> > > of qmp_next. So remove it form the handler.
> > 
> > How big is this buffer ?
> 
> It's 4k

I think that is big enough that it would be better on the heap,
although libxl is quite flabby in its stack use.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel