Re: [Xen-devel] [PATCH V2 1/2] xen/altp2m: set access_required properly for all altp2ms

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Jun 28, 2018 at 10:08:19AM +0300, Razvan Cojocaru wrote:
> >> +{
> >> +    unsigned int i;
> >> +
> >> +    p2m_get_hostp2m(d)->access_required = access_required;
> >> +
> >> +    if ( !altp2m_active(d) )
> >> +        return;
> >> +
> >> +    for ( i = 0; i < MAX_ALTP2M; i++ )
> >> +    {
> >> +        struct p2m_domain *p2m = d->arch.altp2m_p2m[i];
> >> +
> >> +        if ( p2m )
> >> +            p2m->access_required = access_required;
> >> +    }
> > 
> > It seems to me you should check for domain pause count at the beginning
> > of this function to avoid mistakes.
> 
> Do you mean ASSERT(atomic_read(&d->pause_count)); ?

Yes.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel