Re: [Xen-devel] [PATCH 4/6] x86/msr: Clean up the MSR_FEATURE_CONTROL constants

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Tue, Jun 26, 2018 at 02:18:16PM +0100, Andrew Cooper wrote:
> The existing bit names are excessively long (45 chars!), and can be trimmed
> down substantially.  Drop the IA32 prefix and abbreviate FEATURE_CONTROL to
> FEAT_CTL.  Furthermore, all of these are feature enablement bits, so drop
> ENABLE/ON parts of the constants.
> 
> While altering all the users, take the opportunity to introduce cpu_has_smx
> and clean up _vmx_cpu_up() with respect to its MSR_FEATURE_CONTROL handling.
> 
> The SENTER constants are unreferenced and dropped.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

> diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c
> index 884c672..95a0e37 100644
> --- a/xen/arch/x86/hvm/vmx/vmcs.c
> +++ b/xen/arch/x86/hvm/vmx/vmcs.c
> @@ -610,9 +610,9 @@ void vmx_cpu_dead(unsigned int cpu)
>  
>  int _vmx_cpu_up(bool bsp)
>  {
> -    u32 eax, edx;
> -    int rc, bios_locked, cpu = smp_processor_id();
> -    u64 cr0, vmx_cr0_fixed0, vmx_cr0_fixed1;
> +    int rc, cpu = smp_processor_id();

While there you could switch cpu to unsigned int.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel