[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/6] x86/msr: Cleanup of misc constants

On Tue, Jun 26, 2018 at 02:18:14PM +0100, Andrew Cooper wrote:
> Begin the process of cleaning up msr-index.h.  Order the MSRs at the
> head of the file by index, use spaces for indentation, _AC() for bit
> positions, and add a comment describing the expected style.  Abbreviate
> the ARCH_CAPS_* constants to reduce code volume.
> Leave a trailing comment to logically split the file in two, between the
> now-consistent head, and legacy tail which will be improved moving
> forwards.
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>


Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

I would just make the same comment as before about indenting bit
defines of features in MSRs with 2 spaces.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.