Re: [Xen-devel] [PATCH 1/6] x86/msr: Clean up the MSR_EFER constants

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Jun 26, 2018 at 02:18:13PM +0100, Andrew Cooper wrote:
> The bit position constants are only used by the trampoline asm, but the
> code is shorter and clearer when using the mask constants.  This halves
> the number of constants used.
> 
> Consistently use _AC() for the bit constants, and start to use spaces
> for indentation.  Furthermore, EFER contains the NX-Enable bit, to
> rename the constant to EFER_NXE to match both the AMD and Intel specs.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel