Re: [Xen-devel] [PATCH v2 4/6] tools: load IPXE from standalone file

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Mon, Jun 25, 2018 at 12:35:31PM +0100, Wei Liu wrote:
> diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
> index f0fd5fd3a3..1b9e45c492 100644
> --- a/tools/libxl/libxl_dom.c
> +++ b/tools/libxl/libxl_dom.c
> @@ -1128,6 +1128,16 @@ static int libxl__domain_firmware(libxl__gc *gc,
>          if (rc) goto out;
>      }
>  
> +    if (info->type == LIBXL_DOMAIN_TYPE_HVM &&
> +        info->u.hvm.bios == LIBXL_BIOS_TYPE_ROMBIOS &&
> +        libxl__ipxe_path())
> +        rc = xc_dom_module_file(dom, libxl__ipxe_path(), "ipxe");
> +
> +    if (rc) {
> +        rc = ERROR_FAIL;
> +        goto out;
> +    }

IMO I would put the rc check inside the if. And add a LOG message if
xc_dom_module_file fails.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel