[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] device_model_version is set unconditionally to qemu_xen


  • To: xen-devel@xxxxxxxxxxxxx
  • From: Olaf Hering <olaf@xxxxxxxxx>
  • Date: Thu, 21 Jun 2018 15:34:38 +0200
  • Delivery-date: Thu, 21 Jun 2018 13:35:18 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

libxl__domain_build_info_setdefault sets 
libxl_domain_build_info->device_model_version unconditionally to 
LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN. This breaks domUs that do not have a qemu 
attached to it, like PV without vfb= and without qdisk. While that bug does not 
trigger today, it will once 
https://lists.xenproject.org/archives/html/xen-devel/2018-05/msg01077.html is 
merged.

Why would it be a good idea to set ->device_model_version to a bogus value, 
instead of introducing a concept of device_model_version=NONE?

Olaf

Attachment: pgplzYnmnod01.pgp
Description: Digitale Signatur von OpenPGP

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.