[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2] xen/scsiback: add error handling for xenbus_printf


Thank you for the patch! Yet something to improve:

[auto build test ERROR on xen-tip/linux-next]
[also build test ERROR on v4.17 next-20180615]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

base:   https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git linux-next
config: i386-randconfig-x009-201823 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers//xen/xen-scsiback.c: In function 'scsiback_do_add_lun':
>> drivers//xen/xen-scsiback.c:1032:32: error: 'err' undeclared (first use in 
>> this function)
       xenbus_dev_error(info->dev, err,
   drivers//xen/xen-scsiback.c:1032:32: note: each undeclared identifier is 
reported only once for each function it appears in

vim +/err +1032 drivers//xen/xen-scsiback.c

  1010  static void scsiback_do_add_lun(struct vscsibk_info *info, const char 
  1011                                  char *phy, struct ids_tuple *vir, int 
  1012  {
  1013          struct v2p_entry *entry;
  1014          unsigned long flags;
  1016          if (try) {
  1017                  spin_lock_irqsave(&info->v2p_lock, flags);
  1018                  entry = scsiback_chk_translation_entry(info, vir);
  1019                  spin_unlock_irqrestore(&info->v2p_lock, flags);
  1020                  if (entry)
  1021                          return;
  1022          }
  1023          if (!scsiback_add_translation_entry(info, phy, vir)) {
  1024                  if (xenbus_printf(XBT_NIL, info->dev->nodename, state,
  1025                                    "%d", XenbusStateInitialised)) {
  1026                          pr_err("xenbus_printf error %s\n", state);
  1027                          scsiback_del_translation_entry(info, vir);
  1028                  }
  1029          } else if (!try) {
  1030                  if (xenbus_printf(XBT_NIL, info->dev->nodename, state,
  1031                                "%d", XenbusStateClosed))
> 1032                          xenbus_dev_error(info->dev, err,
  1033                                  "%s: writing %s", __func__, state);
  1034          }
  1035  }

0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.