Re: [Xen-devel] [PATCH v3 1/6] vpt: fix create_periodic_time to use the irq parameter

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.06.18 at 17:07, <roger.pau@xxxxxxxxxx> wrote:
> Instead of the stale value inside the periodic_time struct.

I think this wants its title changed, because ...

> --- a/xen/arch/x86/hvm/vpt.c
> +++ b/xen/arch/x86/hvm/vpt.c
> @@ -445,8 +445,8 @@ void create_periodic_time(
>      uint64_t period, uint8_t irq, time_cb *cb, void *data)
>  {
>      if ( !pt->source ||
> -         (pt->irq >= NR_ISAIRQS && pt->source == PTSRC_isa) ||
> -         (pt->irq >= hvm_domain_irq(v->domain)->nr_gsis &&
> +         (irq >= NR_ISAIRQS && pt->source == PTSRC_isa) ||
> +         (irq >= hvm_domain_irq(v->domain)->nr_gsis &&
>            pt->source == PTSRC_ioapic) )
>      {
>          ASSERT_UNREACHABLE();

... further down from here there is a use of the parameter. Maybe
"check" instead of "use"? With that (easy enough to do while
committing)
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel