[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] uapi header dependencies?

>>> On 13.06.18 at 17:03, <jgross@xxxxxxxx> wrote:
> On 13/06/18 15:31, Jan Beulich wrote:
>> Jürgen, Boris,
>> aren't headers in uapi/ directories supposed to be self contained?
> Hmm, there are many uapi headers including stuff from outside uapi.
> I guess it is okay to include headers which are accessible in the
> kernel _and_ under /usr/include or to put such includes under
> #ifdef __KERNEL__
>> The addition done by David in fbc872c38c clearly isn't, as there's
>> no domid_t anywhere in other uapi/ headers afaict. No idea how
>> to reasonably adjust this; I'd in particular dislike using __u16 there,
>> but perhaps that's the only option we have.
> include/uapi/xen/privcmd.h is especially evil: it is including the
> kernel-only xen/interface/xen.h

Oh, indeed - apparently in order to obtain domid_t and xen_pfn_t
(which is precisely what is missing from evtchn.h). What a mess.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.