Re: [Xen-devel] [Qemu-devel] [PATCH v4 11/40] hw/xen: Use the IEC binary prefix definitions

[Eric Blake <eblake@xxxxxxxxxx>]

On 06/12/2018 04:10 PM, Richard Henderson wrote:
> > So there's tradeoffs either way, and you at least need to document in your
> > commit messages what auditing you have done that any type changes introduced by
> > your changes are safe.
> I'm more concerned about unnecessary or unintended signed vs unsigned changes
> than I am about width.  But if we're going to force a 64-bit type, use
> (int64_t)1 not 1LL.  That way the type will match the existing PRId64 printf
> markup.
Or spell it UINT64_C(1) if you don't want a cast.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel