[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v7 06/15] x86/hvm: Introduce hvm_save_mtrr_msr_one func

>>> On 07.06.18 at 16:59, <aisaila@xxxxxxxxxxxxxxx> wrote:
> This is used to save data from a single instance.
> Signed-off-by: Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>

I think it would help if you based this on top of Roger's series[1] right away,
as that one is pretty likely to go in relatively soon after branching. If you
choose to do so, please don't forget to mention the dependency as long
as the other series hasn't gone in.

> --- a/xen/arch/x86/hvm/mtrr.c
> +++ b/xen/arch/x86/hvm/mtrr.c
> @@ -666,36 +666,42 @@ int hvm_set_mem_pinned_cacheattr(struct domain *d, 
> uint64_t gfn_start,
>      return 0;
>  }
> -static int hvm_save_mtrr_msr(struct domain *d, hvm_domain_context_t *h)
> +static void hvm_save_mtrr_msr_one(struct vcpu *v, struct hvm_hw_mtrr 
> *hw_mtrr)
>  {
> +    struct mtrr_state *mtrr_state = &v->arch.hvm_vcpu.mtrr;

const (and in case I've overlooked any such helper pointer in other
patches, please apply this comment there as well)


[1] https://lists.xenproject.org/archives/html/xen-devel/2018-06/msg00487.html

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.