Re: [Xen-devel] [PATCH 3/3] xen/displif: Add unique display connector identifier

[Oleksandr Andrushchenko <andr2000@xxxxxxxxx>]

On 06/07/2018 04:29 PM, Konrad Rzeszutek Wilk wrote:
> On Wed, May 23, 2018 at 09:19:23AM +0300, Oleksandr Andrushchenko wrote:
> > From: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
> >
> > If frontend is configured to expose multiple connectors then backend may
> > require a way to uniquely identify concrete virtual connector within the
> > frontend. This is useful for use-cases where connector needs to be
> > matched to physical display connector.
> > Add XenBus "unique-id" node parameter, so this sort of use-cases can
> > be implemented.
> >
> > Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
> > ---
> >   xen/include/public/io/displif.h | 8 ++++++++
> >   1 file changed, 8 insertions(+)
> >
> > diff --git a/xen/include/public/io/displif.h b/xen/include/public/io/displif.h
> > index 8a94f1f9b9d0..78158f739cf5 100644
> > --- a/xen/include/public/io/displif.h
> > +++ b/xen/include/public/io/displif.h
> > @@ -189,6 +189,13 @@
> >    *
> >    *----------------------------- Connector settings 
> > ----------------------------
> >    *
> > + * unique-id
> > + *      Values:         <uint32_t>
> Ditto, perhaps an string instead?
Ditto ;)
String is way better, but we have to decide if we want to be consistent 
with sndif
> > + *
> > + *      After device instance initialization each connector is assigned a
> > + *      unique ID (within the front driver), so it can be identified by the
> > + *      backend by this ID.
> > + *
> >    * resolution
> >    *      Values:         <width, uint32_t>x<height, uint32_t>
> >    *
> > @@ -368,6 +375,7 @@
> >   #define XENDISPL_FIELD_EVT_CHANNEL    "evt-event-channel"
> >   #define XENDISPL_FIELD_RESOLUTION     "resolution"
> >   #define XENDISPL_FIELD_BE_ALLOC       "be-alloc"
> > +#define XENDISPL_FIELD_UNIQUE_ID      "unique-id"
> >   
> >   /*
> >    
> > ******************************************************************************
> > --
> > 2.17.0
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel