[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Patch "x86/amd: don't set X86_BUG_SYSRET_SS_ATTRS when running under Xen" has been added to the 4.9-stable tree

This is a note to let you know that I've just added the patch titled

    x86/amd: don't set X86_BUG_SYSRET_SS_ATTRS when running under Xen

to the 4.9-stable tree which can be found at:

The filename of the patch is:
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.

From foo@baz Sat Jun  2 15:10:07 CEST 2018
From: Juergen Gross <jgross@xxxxxxxx>
Date: Wed, 30 May 2018 13:09:58 +0200
Subject: x86/amd: don't set X86_BUG_SYSRET_SS_ATTRS when running under Xen
To: stable@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
Cc: dwmw@xxxxxxxxxxxx, boris.ostrovsky@xxxxxxxxxx, Juergen Gross 
Message-ID: <20180530110958.19413-4-jgross@xxxxxxxx>

From: Juergen Gross <jgross@xxxxxxxx>

Upstream commit: def9331a12977770cc6132d79f8e6565871e8e38 ("x86/amd:
don't set X86_BUG_SYSRET_SS_ATTRS when running under Xen")

When running as Xen pv guest X86_BUG_SYSRET_SS_ATTRS must not be set
on AMD cpus.

This bug/feature bit is kind of special as it will be used very early
when switching threads. Setting the bit and clearing it a little bit
later leaves a critical window where things can go wrong. This time
window has enlarged a little bit by using setup_clear_cpu_cap() instead
of the hypervisor's set_cpu_features callback. It seems this larger
window now makes it rather easy to hit the problem.

The proper solution is to never set the bit in case of Xen.

Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
Acked-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
 arch/x86/kernel/cpu/amd.c |    5 +++--
 arch/x86/xen/enlighten.c  |    4 +---
 2 files changed, 4 insertions(+), 5 deletions(-)

--- a/arch/x86/kernel/cpu/amd.c
+++ b/arch/x86/kernel/cpu/amd.c
@@ -857,8 +857,9 @@ static void init_amd(struct cpuinfo_x86
                if (cpu_has(c, X86_FEATURE_3DNOW) || cpu_has(c, X86_FEATURE_LM))
                        set_cpu_cap(c, X86_FEATURE_3DNOWPREFETCH);
-       /* AMD CPUs don't reset SS attributes on SYSRET */
-       set_cpu_bug(c, X86_BUG_SYSRET_SS_ATTRS);
+       /* AMD CPUs don't reset SS attributes on SYSRET, Xen does. */
+       if (!cpu_has(c, X86_FEATURE_XENPV))
+               set_cpu_bug(c, X86_BUG_SYSRET_SS_ATTRS);
 #ifdef CONFIG_X86_32
--- a/arch/x86/xen/enlighten.c
+++ b/arch/x86/xen/enlighten.c
@@ -473,10 +473,8 @@ static void __init xen_init_cpuid_mask(v
 static void __init xen_init_capabilities(void)
-       if (xen_pv_domain()) {
-               setup_clear_cpu_cap(X86_BUG_SYSRET_SS_ATTRS);
+       if (xen_pv_domain())
-       }
 static void xen_set_debugreg(int reg, unsigned long val)

Patches currently in stable-queue which might be from jgross@xxxxxxxx are


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.