Re: [Xen-devel] [PATCH v3 06/10] xen: remove HAS_ prefix from UART Kconfig options

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Tue, 29 May 2018, Jan Beulich wrote:
> >>> On 23.05.18 at 02:25, <sstabellini@xxxxxxxxxx> wrote:
> > UART drivers are now selectable by the user. To mark the change, remove
> > the HAS_ prefix.
> 
> I'm not sure we need to go this far at this point - for MEM_ACCESS this
> looks reasonable, but here it looks more like clutter to me.

Fair enough, I drop this patch.


> > Use HAS_* options to mark which options are available on which
> > architecture. Use HAS_*_ALWAYS_ON options to mark which options are
> > silent and always enabled on a given architecture.
> > 
> > Make NS16550 and EHCI silent and always enabled on x86.
> > Make all the others selectable on ARM, default on.
> 
> Is this last paragraph mostly stale now, with the previous patch
> having most (and supposedly all) of this already?
> 
> > --- a/xen/arch/arm/Kconfig
> > +++ b/xen/arch/arm/Kconfig
> > @@ -20,6 +20,13 @@ config ARM
> >     select HAS_MEM_ACCESS
> >     select HAS_PASSTHROUGH
> >     select HAS_PDX
> > +   select HAS_NS16550
> > +   select HAS_CADENCE_UART
> > +   select HAS_MVEBU
> > +   select HAS_PL011
> > +   select HAS_EXYNOS4210
> > +   select HAS_OMAP
> > +   select HAS_SCIF
> >  
> >  config ARCH_DEFCONFIG
> >     string
> > @@ -29,6 +36,27 @@ config ARCH_DEFCONFIG
> >  config HAS_MEM_ACCESS
> >     def_bool y
> >  
> > +config HAS_NS16550
> > +   def_bool y
> > +
> > +config HAS_CADENCE_UART
> > +   def_bool y
> > +
> > +config HAS_MVEBU
> > +   def_bool y
> > +
> > +config HAS_PL011
> > +   def_bool y
> > +
> > +config HAS_EXYNOS4210
> > +   def_bool y
> > +
> > +config HAS_OMAP
> > +   def_bool y
> > +
> > +config HAS_SCIF
> > +   def_bool y
> 
> Either select plus just bool, or "def_bool y". But see my comment on
> MEM_ACCESS - if others think this patch is worthwhile, I'd prefer if
> things here were done that same way.
> 
> Jan
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel