[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v2 07/10] x86/SVM: Add interrupt management code via AVIC
- To: Jan Beulich <JBeulich@xxxxxxxx>, Janakarajan Natarajan <Janakarajan.Natarajan@xxxxxxx>
- From: "Natarajan, Janakarajan" <jnataraj@xxxxxxx>
- Date: Wed, 30 May 2018 14:47:17 -0500
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Janakarajan.Natarajan@xxxxxxx;
- Cc: Tim Deegan <tim@xxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wei.liu2@xxxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxx, Julien Grall <julien.grall@xxxxxxx>, Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
- Delivery-date: Wed, 30 May 2018 19:47:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On 5/17/2018 9:50 AM, Jan Beulich wrote:
On 07.05.18 at 23:07, <Janakarajan.Natarajan@xxxxxxx> wrote:
+void svm_avic_deliver_posted_intr(struct vcpu *v, u8 vec)
+{
+ struct vlapic *vlapic = vcpu_vlapic(v);
+
+ /* Fallback to use non-AVIC if vcpu is not enabled with AVIC. */
+ if ( !svm_avic_vcpu_enabled(v) )
+ {
+ if ( !vlapic_test_and_set_vector(vec, &vlapic->regs->data[APIC_IRR]) )
+ vcpu_kick(v);
+ return;
+ }
+
+ /* If interrupt is disabled, do not ignore the interrupt */
+ if ( !(guest_cpu_user_regs()->eflags & X86_EFLAGS_IF) )
+ return;
It seems to me that I did comment on this before - I don't think EFLAGS.IF
should be considered here:
+ if ( vlapic_test_and_set_vector(vec, &vlapic->regs->data[APIC_IRR]) )
+ return;
Latching the interrupt into IRR ought to keep it pending until the guest sets
EFLAGS.IF again.
My apologies. I thought I removed that if check. I'll remove it.
Thanks,
Janak
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
