[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 03/10] arm: rename HAS_GICV3 to GICV3



Hi Stefano,

On 23/05/18 01:25, Stefano Stabellini wrote:
HAS_GICV3 has become selectable by the user. To mark the change, rename
the option from HAS_GICV3 to GICV3.

Suggested-by: Julien Grall <julien.grall@xxxxxxx>
Signed-off-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>

Acked-by: Julien Grall <julien.grall@xxxxxxx>

Cheers,


---
Changes in v3:
- no changes

Changes in v2:
- patch added
---
  xen/arch/arm/Kconfig       | 4 ++--
  xen/arch/arm/Makefile      | 4 ++--
  xen/arch/arm/vgic.c        | 2 +-
  xen/arch/arm/vgic/vgic.c   | 2 +-
  xen/include/asm-arm/gic.h  | 4 ++--
  xen/include/asm-arm/vgic.h | 4 ++--
  6 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
index fb69a66..66adce4 100644
--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -39,7 +39,7 @@ config ACPI
          Advanced Configuration and Power Interface (ACPI) support for Xen is
          an alternative to device tree on ARM64.
-config HAS_GICV3
+config GICV3
        bool
        prompt "GICv3 driver"
        depends on ARM_64
@@ -52,7 +52,7 @@ config HAS_GICV3
  config HAS_ITS
          bool
          prompt "GICv3 ITS MSI controller support" if EXPERT = "y"
-        depends on HAS_GICV3 && !NEW_VGIC
+        depends on GICV3 && !NEW_VGIC
config NEW_VGIC
        bool
diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
index a9533b1..b9c2fb7 100644
--- a/xen/arch/arm/Makefile
+++ b/xen/arch/arm/Makefile
@@ -17,7 +17,7 @@ obj-y += domctl.o
  obj-$(EARLY_PRINTK) += early_printk.o
  obj-y += gic.o
  obj-y += gic-v2.o
-obj-$(CONFIG_HAS_GICV3) += gic-v3.o
+obj-$(CONFIG_GICV3) += gic-v3.o
  obj-$(CONFIG_HAS_ITS) += gic-v3-its.o
  obj-$(CONFIG_HAS_ITS) += gic-v3-lpi.o
  obj-y += guestcopy.o
@@ -51,7 +51,7 @@ ifneq ($(CONFIG_NEW_VGIC),y)
  obj-y += gic-vgic.o
  obj-y += vgic.o
  obj-y += vgic-v2.o
-obj-$(CONFIG_HAS_GICV3) += vgic-v3.o
+obj-$(CONFIG_GICV3) += vgic-v3.o
  obj-$(CONFIG_HAS_ITS) += vgic-v3-its.o
  endif
  obj-y += vm_event.o
diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c
index 3fafdd0..7a2c455 100644
--- a/xen/arch/arm/vgic.c
+++ b/xen/arch/arm/vgic.c
@@ -98,7 +98,7 @@ int domain_vgic_register(struct domain *d, int *mmio_count)
  {
      switch ( d->arch.vgic.version )
      {
-#ifdef CONFIG_HAS_GICV3
+#ifdef CONFIG_GICV3
      case GIC_V3:
          if ( vgic_v3_init(d, mmio_count) )
             return -ENODEV;
diff --git a/xen/arch/arm/vgic/vgic.c b/xen/arch/arm/vgic/vgic.c
index a35449b..832632a 100644
--- a/xen/arch/arm/vgic/vgic.c
+++ b/xen/arch/arm/vgic/vgic.c
@@ -974,7 +974,7 @@ unsigned int vgic_max_vcpus(const struct domain *d)
      return min_t(unsigned int, MAX_VIRT_CPUS, vgic_vcpu_limit);
  }
-#ifdef CONFIG_HAS_GICV3
+#ifdef CONFIG_GICV3
  /* Dummy implementation to allow building without actual vGICv3 support. */
  void vgic_v3_setup_hw(paddr_t dbase,
                        unsigned int nr_rdist_regions,
diff --git a/xen/include/asm-arm/gic.h b/xen/include/asm-arm/gic.h
index 58b910f..22fa122 100644
--- a/xen/include/asm-arm/gic.h
+++ b/xen/include/asm-arm/gic.h
@@ -166,7 +166,7 @@
#define DT_MATCH_GIC_V3 DT_MATCH_COMPATIBLE("arm,gic-v3") -#ifdef CONFIG_HAS_GICV3
+#ifdef CONFIG_GICV3
  /*
   * GICv3 registers that needs to be saved/restored
   */
@@ -194,7 +194,7 @@ struct gic_v2 {
   */
  union gic_state_data {
      struct gic_v2 v2;
-#ifdef CONFIG_HAS_GICV3
+#ifdef CONFIG_GICV3
      struct gic_v3 v3;
  #endif
  };
diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h
index 2a58ea3..374fdaa 100644
--- a/xen/include/asm-arm/vgic.h
+++ b/xen/include/asm-arm/vgic.h
@@ -156,7 +156,7 @@ struct vgic_dist {
      struct pending_irq *pending_irqs;
      /* Base address for guest GIC */
      paddr_t dbase; /* Distributor base address */
-#ifdef CONFIG_HAS_GICV3
+#ifdef CONFIG_GICV3
      /* GIC V3 addressing */
      /* List of contiguous occupied by the redistributors */
      struct vgic_rdist_region {
@@ -359,7 +359,7 @@ unsigned int vgic_max_vcpus(const struct domain *d);
  void vgic_v2_setup_hw(paddr_t dbase, paddr_t cbase, paddr_t csize,
                        paddr_t vbase, uint32_t aliased_offset);
-#ifdef CONFIG_HAS_GICV3
+#ifdef CONFIG_GICV3
  struct rdist_region;
  void vgic_v3_setup_hw(paddr_t dbase,
                        unsigned int nr_rdist_regions,


--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.