Re: [Xen-devel] [PATCH v4 05/10] xen/arm: Setup virtual paging for non-boot CPUs on hotplug/resume

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 15/05/18 12:44, Mirela Simonovic wrote:
> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
> index d43c3aa896..924226f63c 100644
> --- a/xen/arch/arm/p2m.c
> +++ b/xen/arch/arm/p2m.c
> @@ -8,6 +8,8 @@
>   #include <xen/iocap.h>
>   #include <xen/mem_access.h>
>   #include <xen/xmalloc.h>
> +#include <xen/cpu.h>
> +#include <xen/notifier.h>
>   #include <public/vm_event.h>
>   #include <asm/flushtlb.h>
>   #include <asm/event.h>
> @@ -1451,10 +1453,12 @@ err:
>       return page;
>   }
>   
> -static void __init setup_virt_paging_one(void *data)
> +/* VTCR value to be configured by all CPUs. Set only once by the boot CPU */
> +static uint64_t __read_mostly vtcr;
This should be uint32_t as VTCR is a 32-bit register. The rest looks 
good to me.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel