Re: [Xen-devel] [PATCH 2/5] x86: split out cpuid objects and helpers

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Thu, May 24, 2018 at 05:05:19PM +0100, Wei Liu wrote:
> They are moved to a new header which is going to be consumed by both
> the hypervisor and toolstack.
> 
> Create a new directory for this kind of headers in anticipation of
                                                                  ^that?
> more will come.
> 
> No functional change.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> 
> Any suggestion on the directory name?
> ---
>  xen/include/asm-x86/arch-shared/cpuid.h | 213 
> ++++++++++++++++++++++++++++++++
>  xen/include/asm-x86/cpuid.h             | 210 +------------------------------

I would have placed those inside of:

xen/include/public/arch-x86/cpuid.h

Protected with a #if defined(__XEN__) || defined(__XEN_TOOLS__)?

That's how structures are generally shared between the toolstack and
the hypervisor. But then that would also require you to prefix those
structures with 'xen_', which will add more churn to the patch...

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel