Re: [Xen-devel] [PATCH v1] libxl: always call qemus xen-save-devices-state in suspend/resume

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, May 22, 2018 at 10:52:20AM +0200, Olaf Hering wrote:
> Am Mon, 21 May 2018 09:18:20 +0100
> schrieb Wei Liu <wei.liu2@xxxxxxxxxx>:
> 
> > What I mean is: now you seem to want to call
> > libxl__domain_suspend_device_model when QEMU upstream is running,
> > regardless of whether a guest is HVM or PV, so the check for HVM should
> > be gone.
> 
> libxl__domain_suspend_device_model calls libxl__device_model_version_running,
> which may return LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN_TRADITIONAL in case
> "dm-version" does not exist.
> Is it valid to assume that a non-existant "dm-version" means qemu-trad?
> So far I have not tested a PV domU with qemu-trad, not sure if that can work
> anyway.
> 
> Also, libxl__device_model_version_running may return -1. Is that valid?
> 

I think your predicate is correct. Sorry for the noise.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel