Re: [Xen-devel] [PATCH for-next 2/5] ipxe: produce a single binary from its build

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, May 18, 2018 at 09:38:01AM -0600, Jan Beulich wrote:
> >>> On 15.05.18 at 20:22, <wei.liu2@xxxxxxxxxx> wrote:
> > --- a/tools/firmware/etherboot/Makefile
> > +++ b/tools/firmware/etherboot/Makefile
> > @@ -18,11 +18,15 @@ D=ipxe
> >  T=ipxe.tar.gz
> >  
> >  ROMS = $(addprefix $D/src/bin/, $(addsuffix .rom, $(ETHERBOOT_NICS)))
> > +ROM = $D/src/bin/ipxe.bin
> >  
> >  .NOTPARALLEL:
> >  
> >  .PHONY: all
> > -all: $(ROMS)
> > +all: $(ROM)
> > +
> > +$(ROM): $(ROMS)
> > +   cat $^ > $@
> 
> Simple commands like this always make me worry what happens if someone
> interrupts the build at the "right" point in time: Does the target file get
> removed in that case, so that a subsequent re-invocation of make will
> correctly rebuild it? If not, you may need to go through an intermediate file,
> which you then rename to $@.

Good point. I will use an intermediary file in my next version.

> 
> hvmloader part
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> 

Thanks.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel