Re: [Xen-devel] [OSSTEST PATCH 08/10] mg-anoint: Support mg-anoint retrieve --tolerate-unprepared

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Thu, May 17, 2018 at 12:16:57PM +0100, Ian Jackson wrote:
> make-*-flight is going to want this.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Just a style comment below.

> ---
>  mg-anoint | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/mg-anoint b/mg-anoint
> index 522cbdd..d09124b 100755
> --- a/mg-anoint
> +++ b/mg-anoint
> @@ -15,10 +15,12 @@
>  #        --allow-blessed=BLESSING,...       default is from `prepare'
>  #        --allow-job-status=STATUS,...      default is only `pass'
>  #
> -#  ./mg-anoint retrieve REFKEY
> +#  ./mg-anoint retrieve [--tolerate-unprepared] REFKEY
>  #      => FLIGHT JOB
>  #         if nothing anointed yet, prints nothing and exits 0
>  #         if anointment not prepared, fails
> +#      With --tolerate-unprepared, it is not an error if nothing is
> +#      reported because the anointment has not been prepared.
>  #
>  #  ./mg-anoint list-prepared REFKEY-GLOB
>  #      => possibly empty list of REFKEYs
> @@ -294,6 +296,11 @@ END
>  }    
>  
>  sub cmd_retrieve {
> +    my $tolerate_unprepared;
> +    if (@ARGV && $ARGV[0] eq '--tolerate-unprepared') {
> +     shift @ARGV;
> +     $tolerate_unprepared = 1;
> +    }

There seems to be a mix between hard and soft tabs in the chunk above
(and below).

Thanks.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel