[Xen-devel] [OSSTEST PATCH] ts-xen-build: run `make build' before `make', by default

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

The Xen build system has some quirks.  One of them is that `make' is a
version of `make dist' which is a version of `make install', which
runs `make install' in each subdir - but there are subdirs where `make
install' is a no-op which does not depend on `make build'.  Also,
`make all' does not do `make build'.  Additionally, the default target
differs in the toplevel, compared to subdirectories.  Perhaps this is
all mistaken, but it's not something we can correct in stable
branches.

The result is that we might miss bugs where `make build' fails; and in
particular, bugs where simply `make' may fail in a subdirectory.  Eg,
the recently discovered build failures in the emulator tests, due to
backported changes, which occur with `make -C tools' but not with
`make all' or `make tools'.

Detect these by running `make build' before `make' (unless our caller
has specified some other build arguments).  In the future perhaps we
should do tools and hypervisor builds entirely separately.

Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
---
v2: Use `make build' instead of `make all' since the former actually
    detects the bug in a buggy unpatched Xen 4.8.  Fix a syntax
    error.  Improve the commit message.
---
 ts-xen-build | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/ts-xen-build b/ts-xen-build
index c5d2a1d..4bf2428 100755
--- a/ts-xen-build
+++ b/ts-xen-build
@@ -160,7 +160,13 @@ END
             fi
 END
 
-    buildcmd_stamped_logged(9000, 'xen', 'build', '',<<END,'');
+    if (!@make_args) {
+       buildcmd_stamped_logged(9000, 'xen', 'build', '',<<END,'');
+            $make_prefix make $makeflags build
+END
+    }
+
+    buildcmd_stamped_logged(9000, 'xen', 'all', '',<<END,'');
             $make_prefix make $makeflags @make_args
 END
 
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel