Re: [Xen-devel] [PATCH for-4.11 v2 2/2] Add new add_maintainers.pl script to optimise the workflow when using git format-patch with get_maintainer.pl

[Lars Kurth <lars.kurth@xxxxxxxxxx>]

On 01/05/2018, 13:52, "Ian Jackson" <ian.jackson@xxxxxxxxxx> wrote:

    Lars Kurth writes ("Re: [PATCH for-4.11 v2 2/2] Add new add_maintainers.pl 
script to optimise the workflow when using git format-patch with 
get_maintainer.pl"):
    > On 30/04/2018, 17:21, "Ian Jackson" <ian.jackson@xxxxxxxxxx> wrote:
    > 
    >     When I do this, there is nothing that gets the CC for the cover letter
    >     right.  (I sometimes bodge it.)  Your tool already knows how to
    >     extract CCs from the individual non-cover-letter patches and add them
    >     to the cover letter.  That is the function I want - to do that, but
    >     not run get_maintainer.
    > 
    > That makes sense and can be easily done via an option: e.g.
    > --insert cover|-i cover or a separate option. Let me know whether
    > you have a preference regarding naming/options.
    
    I think this is orthogonal to -i.  That is, a user who wants your tool
    to only edit the cover letter might want either to have it add the CCs
    only to the mail header, or into the body as well.
    
    Perhaps --transfer-only aka -T ?  Not sure I can think of a good name.

I can do either: in fact looking at the code -i only operates on files that
are not the cover letter. 

So:
-i top: adds CC's to each *.patch except the cover letter
-i ccbody: adds CC's to the body of each *.patch file except the cover letter

Thus
-i none: could just not add anything to each *.patch file except the
 cover letter

I think that is probably the most logical way to do this
I probably need to clarify the scope of -i in the help section

In the cover letter, the tool always insert at the top as it is a transient
thing that does not end up in git.

    As an aside, I guess with `-i ccbody' your tool still puts the CCs in
    the mail headers of the cover letter ?  Or will git-send-email do that ?

git-send-email does that. No need to add extra logic
I will add a comment into the tool's code

Lars
    

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel