Re: [Xen-devel] [PATCH for-4.11 v2 0/2] Add Designated Reviewer (R:) to MAINTAINERS (plus a test case)

[Lars Kurth <lars.kurth@xxxxxxxxxx>]

On 30/04/2018, 08:57, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:

    >>> On 27.04.18 at 20:01, <lars.kurth@xxxxxxxxxx> wrote:
    > This follows up from a conversation after the April x86 community call, 
in 
    > which I had
    > the following action: Lars to propose fixing CC issue in 
xen.git:MAINTAINERS 
    > copying 
    > the R section entries from Linux.git:MAINTAINERS (will need changes to 
    > get_maintainers.pl also)
    > 
    > On 27/4/18 Juergen gave a RAB via IRC
    > 
    > Cc: Lars Kurth <lars.kurth@xxxxxxxxxx>
    > Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    > Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
    > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
    > Cc: Jan Beulich <jbeulich@xxxxxxxx>
    > Cc: Julien Grall <julien.grall@xxxxxxx>
    > Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
    > Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
    > Cc: Tim Deegan <tim@xxxxxxx>
    > Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
    > Cc: Brian Woods <brian.woods@xxxxxxx>
    > Cc: Juergen Gross <jgross@xxxxxxxx>
    > 
    > Release-acked-by: Juergen Gross <jgross@xxxxxxxx>
    > Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
    > 
    > Lars Kurth (2):
    >   Add Brian Woods as Designated reviewer to AMD IOMMU and AMD SVM
    >   Add Designated Reviewer (R:) to MAINTAINERS file and add support for
    >     it in get_maintainer.pl
    
    The order of the patches has been unexpectedly swapped, and seems wrong to
    me now; granted this is only cosmetic if both go in at the same time.
    
That is my fault: I got into trouble with git and must have done something 
wrong. If it helps, I can switch the order and re-send. 

The first patch "Add Brian Woods..." depends on syntax and tools support 
introduced by "Add Designated Reviewer (R:)...". I would say that they probably 
should go in together.

Lars     
    

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel