Re: [Xen-devel] [PATCH v4 7/7] add sleep, msleep and NOW() macros to time manager

[Paul Semel <semelpaul@xxxxxxxxx>]

On 04/13/2018 03:55 PM, Roger Pau Monné wrote:
> > those are helpful macro to use the time manager correctly
> >
> > Signed-off-by: Paul Semel <phentex@xxxxxxxxx>
> > ---
> >
> > Notes:
> >      v4:
> >      - new patch version
> >
> >   common/time.c      | 10 ++++++++++
> >   include/xtf/time.h | 12 ++++++++++++
> >   2 files changed, 22 insertions(+)
> >
> > diff --git a/common/time.c b/common/time.c
> > index 7515eb0..e2779b9 100644
> > --- a/common/time.c
> > +++ b/common/time.c
> > @@ -163,6 +163,16 @@ static inline void mspin_sleep(uint64_t t)
> >       nspin_sleep(nsec);
> >   }
> >   
> > +void sleep(uint64_t t)
> > +{
> > +    spin_sleep(t);
> > +}
> > +
> > +void msleep(uint64_t t)
> > +{
> > +    mspin_sleep(t);
> Why can you just call mspin_sleep msleep directly?
>
> The same applies to spin_sleep.
>
> Also I was expecting to see some kind of test appear at the end of the
> series. You are basically adding a bunch of dead code, since there's
> no user of any of the newly introduced functions.
Actually, I won't be able to add a real XSA test using this feature. Anyway, I 
do think that having the sleep functions will be really useful in the future.
Anyway, I was thinking about adding a test that is calling the gettimeofday 
function or something similar.
What do you think about it ?

--
Paul Semel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel