Re: [Xen-devel] [PATCH 7/7] tools/kdd: mute spurious gcc warning

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Apr 06, 2018 at 04:32:42PM +0200, Marek Marczykowski-Górecki wrote:
> > >> cc1: warnings being treated as errors
> > >> kdd.c:639: error: expected [error|warning|ignored] after ‘#pragma GCC
> > >> diagnostic’
> > >> kdd.c:714: error: expected [error|warning|ignored] after ‘#pragma GCC
> > >> diagnostic’
> > >>
> > >> (Interestingly, my 64-bit build completed without issues)
> > > Hmm... this is messy.
> > >
> > > If you have information about which version does what we can try to
> > > enclose the #pragma's with #if __GCC__.
> > 
> > 
> > Can we instead pre-compute the pointer to pacify the compiler? I haven't
> > seen the original error so I can't test it, but something like
> 
> Nope, it doesn't help. But adding "if (offset > 0)" before that "+=
> offset" does... 
> For me it looks like a gcc bug. Not sure how to deal with this. Enclose
> #pragma with #if __GNUC__ >= 8 ?

I would be fine with this.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel