Re: [Xen-devel] [PATCH v3 2/2] xen/arm: Add Marvell ARMADA 3700 early printk support

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 04/05/2018 11:16 AM, Amit Singh Tomar wrote:
> Signed-off-by: Amit Singh Tomar <amittomer25@xxxxxxxxx>
With one change (see below):

Acked-by: Julien Grall <julien.grall@xxxxxxx>

[...]

> +/*
> + * MVEBU UART wait UART to be ready to transmit
> + * xb: register which contains the UART base address
> + * c: scratch register
> + */
> +.macro early_uart_ready xb c
> +1:
> +        ldrh   w\c, [\xb, #UART_STATUS_REG]  /* status register */
> +        tst    w\c, #(1 << 11)                    /* Check TXFIFO FULL bit */
This is using hard tabulation. Xen coding style request to use soft tab.

I will fix that on commit.

> +        b.ne   1b                            /* Wait for the UART to be ready 
> */
> +.endm
> +
> +/*
> + * MVEBU UART transmit character
> + * xb: register which contains the UART base address
> + * wt: register which contains the character to transmit
> + */
> +.macro early_uart_transmit xb wt
> +       strb  \wt, [\xb, #UART_TX_REG]
> +.endm
> +
> +/*
> + * Local variables:
> + * mode: ASM
> + * indent-tabs-mode: nil
> + * End:
> + */
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel