Re: [Xen-devel] [PATCH v6] new config option vtsc_tolerance_khz to avoid TSC emulation

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Mar 29, 2018 at 02:09:43PM +0200, Olaf Hering wrote:
> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
> index dbb287d6fe..8b898bb3c9 100644
> --- a/tools/libxl/libxl_types.idl
> +++ b/tools/libxl/libxl_types.idl
> @@ -466,6 +466,7 @@ libxl_domain_build_info = Struct("domain_build_info",[
>      ("vcpu_soft_affinity", Array(libxl_bitmap, "num_vcpu_soft_affinity")),
>      ("numa_placement",  libxl_defbool),
>      ("tsc_mode",        libxl_tsc_mode),
> +    ("vtsc_tolerance_khz", uint32),

Given the difference in types here, you need to check for truncation
where the value is assigned from uint32_t to uint16_t.

But why don't you use uint16_t here instead? Is there future plan to
widen it to uint32_t in the hypervisor?

The rest looks correct to me.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel