Re: [Xen-devel] [for-4.11][PATCH v6 16/16] xen: Convert page_to_mfn and mfn_to_page to use typesafe MFN

[Julien Grall <julien.grall@xxxxxxx>]

On 03/22/2018 12:24 PM, Tim Deegan wrote:
> Hi,
Hi Tim,

> At 04:47 +0000 on 21 Mar (1521607657), Julien Grall wrote:
> > Most of the users of page_to_mfn and mfn_to_page are either overriding
> > the macros to make them work with mfn_t or use mfn_x/_mfn because the
> > rest of the function use mfn_t.
> >
> > So make page_to_mfn and mfn_to_page return mfn_t by default. The __*
> > version are now dropped as this patch will convert all the remaining
> > non-typesafe callers.
> >
> > Only reasonable clean-ups are done in this patch. The rest will use
> > _mfn/mfn_x for the time being.
> >
> > Lastly, domain_page_to_mfn is also converted to use mfn_t given that
> > most of the callers are now switched to _mfn(domain_page_to_mfn(...)).
> >
> > Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
> > Acked-by: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
> > Reviewed-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> > Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> > Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>
> > Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> > Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx>
> Thought I'd already acked this for the shadow code, but clearly not.
You acked on the first version. That patch was heavily rework just after 
to drop __mfn_to_page and __page_to_mfn rather. Hence I dropped the acked.
> Sorry for the delay, and:
>
> Acked-by: Tim Deegan <tim@xxxxxxx>
Thank you!

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel