Re: [Xen-devel] [PATCH v5 5/5] x86/msr: handle VMX MSRs with guest_rd/wrmsr()

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 28/02/2018 16:09, Sergey Dyasli wrote:
> @@ -474,6 +505,10 @@ int guest_wrmsr(struct vcpu *v, uint32_t msr, uint64_t 
> val)
>          break;
>      }
>  
> +    case MSR_IA32_VMX_BASIC ... MSR_IA32_VMX_VMFUNC:
> +        /* None of these MSRs are writeable. */
> +        goto gp_fault;

There is a block at the top of the switch statement for read-only MSRs
(so they can be more easily removed when we finally get rid of the
legacy MSR paths).  With this moved, Reviewed-by: Andrew Cooper
<andrew.cooper3@xxxxxxxxxx>

> +
>      default:
>          return X86EMUL_UNHANDLEABLE;
>      }
>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel