Re: [Xen-devel] [PATCH 3/3] x86/pv: Minor tweaks to {, compat_}register_guest_callback()

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Thu, Mar 15, 2018 at 11:58:42AM +0000, Andrew Cooper wrote:
>  * Being internal functions, use int rather than long for the return value
>  * Factor out pv_vcpu into a local variable.  Reduces code volume, and removes
>    some split lines.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

register_guest_callback and compat_register_guest_callback are fairly
similar, I wonder if we could translate compat_callback_register into
callback_register and pass an extra compat parameter to
register_guest_callback in order to get rid of
compat_register_guest_callback.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel