Re: [Xen-devel] [PATCH 20/20] xen/domain: Allocate d->vcpu[] in arch_domain_create()

[Julien Grall <julien.grall@xxxxxxx>]

(+ Andre)

On 03/19/2018 07:13 PM, Andrew Cooper wrote:
> On the ARM side, audit config->max_vcpus after the vgic has been initialised,
> at which point we have a real upper bound to test against.  This allows for
> the removal of the vgic_max_vcpus() juggling to cope with the call from
> evtchn_init() before the vgic settings are known.
I would rather keep vgic_max_vcpus() around. We are introducing a new 
vGIC in Xen that will cohabit with the current vGIC for a few releases. 
See [1].
So a better solution is to rework vgic_max_vcpus() to drop the NULL check.

I would also fine to directly call vgic_max_vcpus() in 
arch_domain_create and therefore drop domain_max_vcpus().
Cheers,

[1] https://lists.xen.org/archives/html/xen-devel/2018-03/msg01831.html

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel