Re: [Xen-devel] [RFC PATCH 02/12] Makefile: build and use new DSDT table for Q35

[Alexey G <x1917x@xxxxxxxxx>]

On Mon, 19 Mar 2018 07:07:34 -0600
"Jan Beulich" <JBeulich@xxxxxxxx> wrote:

>>>> On 12.03.18 at 19:33, <x1917x@xxxxxxxxx> wrote:  
>> --- a/tools/firmware/hvmloader/Makefile
>> +++ b/tools/firmware/hvmloader/Makefile
>> @@ -75,7 +75,7 @@ rombios.o: roms.inc
>>  smbios.o: CFLAGS += -D__SMBIOS_DATE__="\"$(SMBIOS_REL_DATE)\""
>>  
>>  ACPI_PATH = ../../libacpi
>> -DSDT_FILES = dsdt_anycpu.c dsdt_15cpu.c dsdt_anycpu_qemu_xen.c
>> +DSDT_FILES = dsdt_anycpu.c dsdt_15cpu.c dsdt_anycpu_qemu_xen.c
>> dsdt_q35_anycpu_qemu_xen.c  
>
>Unless you intend to add a second flavor, please omit the "anycpu"
>part from the name of the new instance.

Just following same "anycpu/15cpu" naming scheme, there will be no need
for dsdt_q35_15cpu.c, so I guess its ok to drop anycpu/15cpu part of
the name, will rename it.

>> @@ -56,6 +56,13 @@ $(ACPI_BUILD_DIR)/dsdt_anycpu_qemu_xen.asl:
>> dsdt.asl dsdt_acpi_info.asl $(MK_DSD $(MK_DSDT) --debug=$(debug)
>> --dm-version qemu-xen >> $@.$(TMP_SUFFIX) mv -f $@.$(TMP_SUFFIX) $@
>>  
>> +$(ACPI_BUILD_DIR)/dsdt_q35_anycpu_qemu_xen.asl: dsdt_q35.asl
>> dsdt_acpi_info.asl $(MK_DSDT)
>> +    # Remove last bracket
>> +    awk 'NR > 1 {print s} {s=$$0}' $< > $@.$(TMP_SUFFIX)
>> +    cat dsdt_acpi_info.asl >> $@.$(TMP_SUFFIX)
>> +    $(MK_DSDT) --debug=$(debug) --dm-version qemu-xen >>
>> $@.$(TMP_SUFFIX)
>> +    mv -f $@.$(TMP_SUFFIX) $@  
>
>The commands look to be exactly the same as those for
>dsdt_anycpu_qemu_xen.asl - please let's not duplicate such
>things, but instead use a pattern rule.

Agree, reusing the rule will be better.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel