Re: [Xen-devel] [PATCH 1/5] tools/firmware: Build ipxe as a standalone ROM

[Doug Goldstein <cardoe@xxxxxxxxxx>]

On 3/16/18 6:18 AM, Jan Beulich wrote:
>>>> On 15.03.18 at 18:31, <anoob.soman@xxxxxxxxxx> wrote:
>> @@ -71,7 +72,7 @@ all: acpi subdirs-all
>>  acpi:
>>      $(MAKE) -C $(ACPI_PATH)  ACPI_BUILD_DIR=$(CURDIR) 
>> DSDT_FILES="$(DSDT_FILES)"
>>  
>> -rombios.o: roms.inc
>> +rombios.o: $(ETHERBOOT_ROM) roms.inc
> 
> Please don't introduce dead dependencies: If a need for this arises
> in a later patch, add the dependency there.

Well this is what's creating the ipxe.bin that's being installed in the
section you snipped out.

But I kind of agree. I feels like patch 1 & 2 belong together maybe?

-- 
Doug Goldstein

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel