Re: [Xen-devel] [PATCH v5 11/16] xen/mm: Switch some of page_alloc.c to typesafe MFN

[Julien Grall <julien.grall@xxxxxxx>]

Hi George,

Thank you for the review.

On 15/03/18 17:02, George Dunlap wrote:
> On 03/14/2018 06:20 PM, julien.grall@xxxxxxx wrote:
> > From: Julien Grall <julien.grall@xxxxxxx>
> >
> > No functional change intended.
> >
> > Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
> > Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> This patch by itself doesn't look like it actually makes things simpler
> in general, but I'll trust that it will in the future:
I think it would be possible to do further clean-up. What I wanted to 
avoid is having mfn_x(page_to_mfn(pg)) all around the code after page 
#16 because the override is dropped.
> Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx>
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel