Re: [Xen-devel] [PATCH v3 3/6] x86: log XPTI enabled status

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 15.03.18 at 16:56, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 13/03/18 13:48, Jan Beulich wrote:
>> At the same time also report the state of the two defined
>> ARCH_CAPABILITIES MSR bits. To avoid further complicating the
>> conditional around that printk(), drop it (it's a debug level one only
>> anyway).
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> Tested-by: Juergen Gross <jgross@xxxxxxxx>
>> Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
> 
> In principle, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> 
> However, don't we want to take the opportunity to raise the XENLOG_INFO
> to something which will be printed by default in a release build, seeing
> as that plan fell through the first time?

Well, strictly speaking I don't think this patch should alter the
BTI related printk(), and I do think the one added here should
be in sync with the other one. But I wouldn't mind making both
XENLOG_WARNING (or perhaps better omit XENLOG_* altogether
from these two). I could easily alter this before committing, but
none of these can be committed afaict without us reaching
agreement on patch 1 (the dependencies between the patches
are also the reason why I didn't re-order what is still patch 1,
other than I had first intended to do for v3).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel