Re: [Xen-devel] [PATCH v4 16/16] xen: Convert page_to_mfn and mfn_to_page to use typesafe MFN

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 14.03.18 at 18:02, <julien.grall@xxxxxxx> wrote:
> On 03/02/2018 04:08 PM, Jan Beulich wrote:
>>>>> On 21.02.18 at 15:02, <julien.grall@xxxxxxx> wrote:
>>> --- a/xen/arch/x86/pv/emul-priv-op.c
>>> +++ b/xen/arch/x86/pv/emul-priv-op.c
>>> @@ -43,16 +43,6 @@
>>>   #include "emulate.h"
>>>   #include "mm.h"
>>>   
>>> -/* Override macros from asm/page.h to make them work with mfn_t */
>>> -#undef mfn_to_page
>>> -#define mfn_to_page(mfn) __mfn_to_page(mfn_x(mfn))
>>> -#undef page_to_mfn
>>> -#define page_to_mfn(pg) _mfn(__page_to_mfn(pg))
>>> -
>>> -/***********************
>>> - * I/O emulation support
>>> - */
>> 
>> Why does this comment go away?
> 
>  From an earlier review, Andrew said:
> 
> "If you're making this change, please take out the Descriptor Tables
> comment like you do with I/O below, because the entire file is dedicated
> to descriptor table support and it will save me one item on a cleanup
> patch :)."

Well, the reasoning isn't really correct, but I agree the comment is at
least misplaced. Hence I'm fine with it being dropped, despite it being
very unrelated to the purpose of the patch. IOW my ack stands with
this one remark un-addressed.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel