Re: [Xen-devel] [PATCH v2 1/4] x86/PVHv2: Add memory map pointer to hvm_start_info struct

[Maran Wilson <maran.wilson@xxxxxxxxxx>]

On 3/14/2018 10:28 AM, Boris Ostrovsky wrote:
> On 03/14/2018 03:55 AM, Jan Beulich wrote:
> > > > > On 14.03.18 at 00:31, <maran.wilson@xxxxxxxxxx> wrote:
> > > + * For x86 implementations at least, the values used in the type field will
> > > + * match the Address Range Types as defined in section 15 (System Address
> > > + * Map Interfaces) of the ACPI Specification (http://uefi.org/specifications)
> > > + * where:
> > > + *     AddressRangeMemory = 1 (E820_RAM)
> > > + *     AddressRangeReserved = 2 (E820_RESERVED)
> > > + *     AddressRangeACPI = 3 (E820_ACPI)
> > > + *     AddressRangeNVS = 4 (E820_NVS)
> > > + *     AddressRangeUnusable = 5 (E820_UNUSABLE)
> > > + *     AddressRangeDisabled = 6 (E820_DISABLED)
> > > + *     AddressRangePersistentMemory = 7 (E820_PMEM)
> > Would you mind waiting for a discussion to settle before sending
> > out new patch versions? As indicated in an earlier reply to v1, I
> > consider this still insufficient. And no, I'm not asking for you to
> > add redundant and potentially conflicting definitions of E820_*,
> > but instead you want to use Xen specific ones (prefixed e.g.
> > by XEN_HVM_MEMMAP_TYPE_).
> Since we will now have a non-Xen user of this interface perhaps
> PVH_MEMMAP_TYPE_ ?
OK, I think I'm following the specifics now. But just to make sure we 
all on the same page before sending out the next version...
I'll be adding something like the following to the header file:

...
/*
 * For x86 implementations at least, the values used in the type field 
of the
 * memory map table entries are defined below and match the Address 
Range Types
 * as defined in section 15 (System Address Map Interfaces) of the ACPI
 * Specification (http://uefi.org/specifications)
 */
#define PVH_MEMMAP_TYPE_RAM       1
#define PVH_MEMMAP_TYPE_RESERVED  2
#define PVH_MEMMAP_TYPE_ACPI      3
#define PVH_MEMMAP_TYPE_NVS       4
#define PVH_MEMMAP_TYPE_UNUSABLE  5
#define PVH_MEMMAP_TYPE_PMEM      7
...

And then we will find an appropriate place in the c code to add a couple 
of BUILD_BUG_ON() macros to make sure the above remain consistent with 
E820_xxx.
Does that sound about right?

Thanks,
-Maran

> -boris

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel