Re: [Xen-devel] [PATCH] xl/libxl: add pvcalls support

[George Dunlap <dunlapg@xxxxxxxxx>]

On Tue, Mar 13, 2018 at 2:13 PM, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> On Tue, Feb 27, 2018 at 01:28:08PM -0800, Stefano Stabellini wrote:
>> Add pvcalls support to libxl and xl. Create the appropriate pvcalls
>> entries in xenstore.
>>
>> Signed-off-by: Stefano Stabellini <stefano@xxxxxxxxxxx>
>
> The code looks fine.
>
> I only want to have a second opinion on
>
>> @@ -829,6 +835,7 @@ libxl_domain_config = Struct("domain_config", [
>>      ("vkbs", Array(libxl_device_vkb, "num_vkbs")),
>>      ("vtpms", Array(libxl_device_vtpm, "num_vtpms")),
>>      ("p9s", Array(libxl_device_p9, "num_p9s")),
>> +    ("pvcallss", Array(libxl_device_pvcalls, "num_pvcallss")),
>
> this...
>
> I think the two s'es look a bit strange. But I don't have a better idea.

That does look a bit Gollum-like, my precioussss.  Call individual
connections a "pvcalldev", and then have it "pvcalldevs" and
"num_pvcalldevs"?

Alternately, only allow a single pvcall connection?

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel