Re: [Xen-devel] [PATCH 2/7] xen/domain: Drop all DOMCRF_* constants

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Mar 09, 2018 at 01:18:37PM +0000, Andrew Cooper wrote:
> diff --git a/xen/common/domctl.c b/xen/common/domctl.c
> index 50f7422..a73e1a4 100644
> --- a/xen/common/domctl.c
> +++ b/xen/common/domctl.c
> @@ -498,7 +498,6 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) 
> u_domctl)
>      {
>          domid_t        dom;
>          static domid_t rover = 0;
> -        unsigned int domcr_flags;
>  
>          ret = -EINVAL;
>          if ( (op->u.createdomain.flags &
> @@ -533,19 +532,8 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) 
> u_domctl)
>              rover = dom;
>          }
>  
> -        domcr_flags = 0;
> -        if ( op->u.createdomain.flags & XEN_DOMCTL_CDF_hvm_guest )
> -            domcr_flags |= DOMCRF_hvm;
> -        if ( op->u.createdomain.flags & XEN_DOMCTL_CDF_hap )
> -            domcr_flags |= DOMCRF_hap;
> -        if ( op->u.createdomain.flags & XEN_DOMCTL_CDF_s3_integrity )
> -            domcr_flags |= DOMCRF_s3_integrity;
> -        if ( op->u.createdomain.flags & XEN_DOMCTL_CDF_oos_off )
> -            domcr_flags |= DOMCRF_oos_off;
> -        if ( op->u.createdomain.flags & XEN_DOMCTL_CDF_xs_domain )
> -            domcr_flags |= DOMCRF_xs_domain;
> -

Please consider adding a test to reject flags Xen doesn't recognise.

The rest looks OK.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel