Re: [Xen-devel] [PATCH 1/1] x86/PVHv2: Add memory map pointer to hvm_start_info struct

[Daniel Kiper <daniel.kiper@xxxxxxxxxx>]

On Fri, Mar 02, 2018 at 02:29:29PM -0800, Maran Wilson wrote:
> On 3/2/2018 1:20 PM, Konrad Rzeszutek Wilk wrote:
> >On Fri, Mar 02, 2018 at 12:54:29PM -0800, Maran Wilson wrote:
> >>The start info structure that is defined as part of the x86/HVM direct boot
> >>ABI and used for starting Xen PVH guests would be more versatile if it also
> >>included a way to pass information about the memory map to the guest. This
> >>would allow KVM guests to share the same entry point.
> >Would it be better if there was an tag/length as well? And maybe more dynamic
> >so that if you want to add more structures you can identify them tags?
> >Like what Multiboot2 has?
>
> That sounds like a decent idea if we expect this structure to
> continue to grow and expand in the future. But I'd be hesitant to
> make it part of this patch series. Mostly because it doesn't add
> value to the existing use case(s) and there's a risk we end up going
> down a less than ideal path trying to design for anticipated (but
> presently unknown) use cases.
>
> I don't think the currently proposed changes would prevent us from
> doing something like you describe in the future, so I guess I'd
> prefer to leave that discussion for if/when we run into additional
> use cases that require new structures. But if there is overwhelming
> support for the idea, I can work on drafting up a proposal for what
> that would look like.

Granted! However, if you change your mind or circumstances have changed
just take a look at Multiboot2 spec. There is a chance that you can use
it as is or if it is not possible you can add what you need. Or in the
worst case you can steal the idea.

Daniel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel