[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 06/16] xen/x86: Remove unused override of page_to_mfn/mfn_to_page



Hi Jan,

On 02/03/18 15:11, Jan Beulich wrote:
On 02.03.18 at 15:44, <julien.grall@xxxxxxx> wrote:
On 02/03/18 14:42, Jan Beulich wrote:
On 21.02.18 at 15:02, <julien.grall@xxxxxxx> wrote:
A few files override page_to_mfn/mfn_to_page but actually never use
those macros. So drop them.

Signed-off-by: Julien Grall <julien.grall@xxxxxxx>

It doesn't look like there are any risky uses of the removed
symbols in the headers, so
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
assuming this has been build-tested in relevant configurations.

All patches have been build-tested one by one.

I've taken that for given. I did say "in relevant configurations"
because things like BIGMEM=y or SHADOW_PAGING=n may
cause issues despite a "normal" build having gone fine.

I have now built test this patch with BIGMEM=y, SHADOW_PAGING=n and saw not compilation errors.

Cheers,


Jan


--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.