Re: [Xen-devel] [PATCH RFC 02/10] passthrough: split out x86 PCI code to x86/pci.c

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 21/02/18 21:46, Wei Liu wrote:
> Move the functions that reference x86 hvm data structures to its own
> file.  Rename pci_clean_dpci_irqs to arch_pci_clean_irqs.
NIT: Double space.

> There is still one location in that file which references
> arch.hvm_domain, but it is fine because ARM guest is HVM.
I guess you mean hvm_domain.mem_sharing_enabled? If so, we don't support 
memory sharing on ARM. This would need to be stub.
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
> Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> Cc: Julien Grall <julien.grall@xxxxxxx>
> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>
> ARM doesn't select HAS_PCI, that's why ARM build is not broken by
> this. AIUI ARM will select HAS_PCI at some point, hence I only move
> the x86 bits.
Potentially there are more x86-ism in that code such as the way to 
handle MSI. Anyway, this patch makes sense from an Arm perspective:
Acked-by: Julien Grall <julien.grall@xxxxxxx>

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel