[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] build: Rename as-insn-check to as-insn-add

>>> On 22.02.18 at 11:51, <andrew.cooper3@xxxxxxxxxx> wrote:
> as-insn-check mutates the passed-in flags.  Rename it to as-insn-add, in line
> with cc-option-add.  Update all callers.

I'm not convinced - cc-option-add makes relatively clear that
something is being added to the options passed to CC. If I
take as-insn-add this way, the macro would need to add an
insn to the AS invocation. While I agree as-insn-check doesn't
make clear that it adds any options, I still find this less
misleading than the suggested new name. Let's see what
others think.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.