[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [RFC PATCH 01/10] Add CONFIG_VGIC_ERRATA

On 21/02/18 15:17, Manish Jaggi wrote:
Hi Julien,

On 01/25/2018 07:18 PM, Julien Grall wrote:
Hi Manish,

On 16/01/18 15:42, mjaggi@xxxxxxxxxxxxxxxxxx wrote:
From: Manish Jaggi <manish.jaggi@xxxxxxxxxx>

Add a config option to enable VGIC Errata Code in Xen. Platforms which do not
have this errta can compile out this feature.


Signed-off-by: Manish Jaggi <manish.jaggi@xxxxxxxxxx>
  xen/arch/arm/Kconfig | 9 +++++++++
  1 file changed, 9 insertions(+)

diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
index f58019d6ed..2966e3a3d3 100644
--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -59,6 +59,15 @@ config SBSA_VUART_CONSOLE
  +menu "Errata Workarounds"
+       depends on ARM_64

I would much prefer to see the memu "ARM errata workaround via..." renamed to "Errata Workarounds". So we have only one menu with all workarounds.
I am not sure it would work as
menu "ARM errata workaround via the alternative framework"
         depends on HAS_ALTERNATIVE

which may not be correct for vGIC errata.

vGIC errata are likely going to be based on alternative. So the call to the function could be avoided on non-affected platform.

But as alternative is supported unconditionally by both Arm64 and Arm32, this depends could just be dropped.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.