[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 1/4] build: filter out command line assembler arguments

>>> On 19.02.18 at 17:05, <roger.pau@xxxxxxxxxx> wrote:
> On Mon, Feb 19, 2018 at 08:43:51AM -0700, Jan Beulich wrote:
>> >>> On 19.02.18 at 15:16, <roger.pau@xxxxxxxxxx> wrote:
>> > ---
>> >  xen/arch/x86/Makefile | 6 +++---
>> >  xen/arch/x86/Rules.mk | 5 +----
>> >  xen/include/Makefile  | 2 +-
>> >  3 files changed, 5 insertions(+), 8 deletions(-)
>> What about the "%.i: %.c", "%.s: %.c", and "%.s: %.S" rules
>> near the end of xen/Rules.mk?
> Hm, those rules don't seem to be used at all in x86, are they not
> needed anymore because there are more specific rules instead?
> I can add the filtering there, but maybe it would be better to simply
> remove those?

No, don't, ever. They're not needed for a _normal_ build, but in case
of build problems they may be needed for analyzing the issue, i.e.
when you need to look at one of the intermediate files. I happen to
use this every once in a while, especially when macro invocations
nest so deeply that the compiler doesn't produce useful location
information anymore.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.