Re: [Xen-devel] [PATCH] shim: allow building of just the shim with build-ID-incapable linker

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Mon, Feb 19, 2018 at 06:23:09AM -0700, Jan Beulich wrote:
> The ELF note the shim build inserts causes mkelf32 to choke on the
> second program header. However, the output of mkelf32 isn't really
> needed when building inside tools/firmware/ - an attempt to build it is
> made solely because of a wrong dependency.
> 
> Further changes to the make logic will be needed to also allow building
> a shim-enabled "normal" xen with such a linker (as it looks the --notes
> option will need passing not just when the linker support build ID
> generation).
> 
> Also drop a stray variable setting from the x86 Makefile.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks, there certainly no need to build the regular xen target AFAICT
if only xen-shim is desired.

I also assume that passing --notes to mkelf32 when building the shim
(regardless of whether the linker supports build ID or not) should
also fix the issue?

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel