Re: [Xen-devel] [PATCH] x86/spec_ctrl: Fix several bugs in SPEC_CTRL_ENTRY_FROM_INTR_IST

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 14/02/18 11:47, Roger Pau Monné wrote:
>
>> diff --git a/xen/include/asm-x86/spec_ctrl_asm.h 
>> b/xen/include/asm-x86/spec_ctrl_asm.h
>> index 814f53d..1f78599 100644
>> --- a/xen/include/asm-x86/spec_ctrl_asm.h
>> +++ b/xen/include/asm-x86/spec_ctrl_asm.h
>> @@ -79,10 +79,10 @@
>>   *  - SPEC_CTRL_EXIT_TO_GUEST
>>   */
>>  
>> -.macro DO_OVERWRITE_RSB
>> +.macro DO_OVERWRITE_RSB tmp=%rax
>>  /*
>>   * Requires nothing
>> - * Clobbers %rax, %rcx
>> + * Clobbers \tmp (%rax by default), %rcx
> Is it worth changing %rcx to %ecx here...

No, because a mov to %ecx clobbers %rcx.  I'll adjust the comment.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel